From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22170 invoked by alias); 28 Jan 2011 16:01:10 -0000 Received: (qmail 22137 invoked by uid 22791); 28 Jan 2011 16:01:07 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Jan 2011 16:01:02 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0SG10Dg000702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 28 Jan 2011 11:01:01 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p0SG10Lm015686; Fri, 28 Jan 2011 11:01:00 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p0SG0xJF019702; Fri, 28 Jan 2011 11:01:00 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 9548A3784E2; Fri, 28 Jan 2011 09:00:59 -0700 (MST) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch] Support inferior events in python References: <4D2342A2.7060102@redhat.com> <4D34AF3F.4090006@redhat.com> <4D39FFFD.80304@redhat.com> Date: Fri, 28 Jan 2011 16:21:00 -0000 In-Reply-To: <4D39FFFD.80304@redhat.com> (sami wagiaalla's message of "Fri, 21 Jan 2011 16:51:57 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00552.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> Okay, I added exit_code to struct inferior, set it and used it. How Sami> does that part of the patch look ? It seems reasonable to me, but while looking I ran across get_last_target_status. Can we use that instead? It isn't super to rely on globals like this, but existing globals are grandfathered in... Sami> + current_inferior ()->exit_code = (LONGEST) ecs->ws.value.integer; If we keep this approach then I think you do not need this cast. Sami> + gdbpy_breakpoint_from_bpstats (bs)) < 0) I think it is possible for gdbpy_breakpoint_from_bpstats to return NULL. This is not really an error condition; it just means that this breakpoint has no corresponding Python object. I am not sure what to do in this case, but we definitely can't do this :-) Sami> + event = create_continue_event_object (); Are continue events symmetric to stop events, meaning that it should indicate which threads were continued? This is looking quite good. Tom