From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19184 invoked by alias); 23 May 2011 15:40:59 -0000 Received: (qmail 19123 invoked by uid 22791); 23 May 2011 15:40:58 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 May 2011 15:40:44 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4NFeSOG015265 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 23 May 2011 11:40:28 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p4NFeRFG019750; Mon, 23 May 2011 11:40:28 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4NFeRQu004015; Mon, 23 May 2011 11:40:27 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id CFE273791A0; Mon, 23 May 2011 09:40:26 -0600 (MDT) From: Tom Tromey To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] dwarf2read.c: handle alternate dwarf2 debug sections name. References: <1306146544-3925-1-git-send-email-gingold@adacore.com> <1306146544-3925-3-git-send-email-gingold@adacore.com> Date: Mon, 23 May 2011 15:40:00 -0000 In-Reply-To: <1306146544-3925-3-git-send-email-gingold@adacore.com> (Tristan Gingold's message of "Mon, 23 May 2011 12:29:02 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00531.txt.bz2 Tristan> Simply because the XCOFF maintainer was against this approach: Tristan> http://sourceware.org/ml/binutils/2011-04/msg00364.html I see. Onward, then. Also I see my other note was completely in error. Sigh. Sorry about that. I'll reply to that to eliminate confusion. I have a few nits with this patch, nothing serious. Tristan> + bfd_map_over_sections (objfile->obfd, dwarf2_locate_sections, Tristan> + (void *)names); Space after ")". Tristan> + names = (const struct dwarf2_debug_sections *)vnames; You shouldn't need the cast, but if for some reason you do, there should be a space after the ")". Tristan> +struct dwarf2_section_names { Tristan> + const char *normal; Tristan> + const char *compressed; Tristan> +}; Tristan> + Tristan> +struct dwarf2_debug_sections { These should both have introductory comments explaining the purpose of the structs. Ok with those changes. Tom