From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81299-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6045 invoked by alias); 26 May 2011 17:07:04 -0000
Received: (qmail 6033 invoked by uid 22791); 26 May 2011 17:07:03 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 May 2011 17:06:49 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4QH6VIG024033	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 26 May 2011 13:06:40 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p4QGXKRF005402;	Thu, 26 May 2011 12:33:20 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4QGXJr3005171;	Thu, 26 May 2011 12:33:19 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 7726C3781A7; Thu, 26 May 2011 10:33:19 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,        Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [_Complex test 1/4]  support_complex_tests in gdb.exp and pass _Complex args to func
References: <4DC401D0.1050500@codesourcery.com>	<Pine.LNX.4.64.1105061426440.8538@digraph.polyomino.org.uk>	<4DC75036.4040806@codesourcery.com> <m3oc3bud5j.fsf@fleche.redhat.com>	<4DD49BE7.80206@codesourcery.com>	<201105190814.p4J8EMYF020774@glazunov.sibelius.xs4all.nl>	<Pine.LNX.4.64.1105191014340.8691@digraph.polyomino.org.uk>	<4DD51A55.9000209@codesourcery.com> <m3mxiiboro.fsf@fleche.redhat.com>	<4DD621CE.2050509@codesourcery.com>
Date: Thu, 26 May 2011 17:07:00 -0000
In-Reply-To: <4DD621CE.2050509@codesourcery.com> (Yao Qi's message of "Fri, 20	May 2011 16:09:50 +0800")
Message-ID: <m3zkm9zak0.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00610.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Tom> I am curious if you tested this in some situation where the complex
Tom> tests are skipped.

Yao> I simulate the `complex-unsupported platform' by removing "o" in keyword
Yao> "double" in support_complex_tests, "_Complex double cd;" -> "_Complex
Yao> duble cd;", and run gdb.base/varargs.exp again.  As you can see,
Yao> _Complex related tests are skipped.

Sounds good, thanks.

Just a couple trivial nits.

Yao> +proc  complex_integral_args {} {

Extra space.

Yao> +# Locate acual args; _Complex types and integral/float.

Typo: actual.

Ok with those fixed.

Tom