From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25749 invoked by alias); 7 Jun 2011 20:56:25 -0000 Received: (qmail 25740 invoked by uid 22791); 7 Jun 2011 20:56:25 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Jun 2011 20:56:03 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p57Ku2ow017451 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 7 Jun 2011 16:56:02 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p57KUPfY011125; Tue, 7 Jun 2011 16:30:25 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p57KUOiq021411; Tue, 7 Jun 2011 16:30:24 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 2C1773781E9; Tue, 7 Jun 2011 14:30:24 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/2] physname reg.: linespec minsym fallback References: <20110605202645.GB20427@host1.jankratochvil.net> Date: Tue, 07 Jun 2011 20:56:00 -0000 In-Reply-To: <20110605202645.GB20427@host1.jankratochvil.net> (Jan Kratochvil's message of "Sun, 5 Jun 2011 22:26:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00105.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2011-06-05 Jan Kratochvil Jan> Fall back linespec to minimal symbols. Jan> * linespec.c (decode_line_1): New variable ex, saved_argptr. Protect Jan> decode_compound by TRY_CATCH, fall back on minsyms if it failed. Jan> (find_method, symbol_found): Change error to cplusplus_error. This looks like it will conflict with one of Keith's patches, which touches the same code. I think we should review those first, just on the grounds that they have been in development longer and were submitted first. Tom