From: Phil Muldoon <pmuldoon@redhat.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] [python] gdb.Inferior reference count fixes
Date: Thu, 30 Jun 2011 12:57:00 -0000 [thread overview]
Message-ID: <m3zkkziiji.fsf@redhat.com> (raw)
In-Reply-To: <BANLkTikPZb1qvc+BLeAOvYenr3ZVYuG7oA@mail.gmail.com> (Kevin Pouget's message of "Thu, 30 Jun 2011 14:40:50 +0200")
Kevin Pouget <kevin.pouget@gmail.com> writes:
> Hi Phil,
>
> thanks for your offer to split the patch this way, I hope that the FSF
> paperwork won't take too long so that we can apply these patches
Hope so too! This patch does not have a dependency on your patch so
(pending approval) it could go in now.
> just one thing:
>
> + thread_object *found = NULL;
> ...
> + if (found)
> + return found;
> return NULL;
>
> the last lines are equivalent to: return found; is it on purpose (ie,
> for readability) ?
I think this was a rewrite and I missed that hunk. It is correct, if
redundant. Thanks for spotting it. I'll alter it locally.
Cheers
Phil
next prev parent reply other threads:[~2011-06-30 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 11:43 Phil Muldoon
2011-06-30 12:41 ` Kevin Pouget
2011-06-30 12:57 ` Phil Muldoon [this message]
2011-06-30 19:52 ` Tom Tromey
2011-07-11 14:37 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zkkziiji.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevin.pouget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox