From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2840 invoked by alias); 7 Jul 2011 19:38:23 -0000 Received: (qmail 2832 invoked by uid 22791); 7 Jul 2011 19:38:22 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Jul 2011 19:38:07 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p67JbriH031043 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Jul 2011 15:37:53 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p67JbqKb023235; Thu, 7 Jul 2011 15:37:53 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p67JboAb011059; Thu, 7 Jul 2011 15:37:51 -0400 From: Tom Tromey To: Fawzi Mohamed Cc: ext Jan Kratochvil , , ext Tristan Gingold , =?utf-8?B?QW5kcsOpIFDDtm5pdHo=?= Subject: Re: [PATCH,gdb,Update4]: ensures that cie ptr of an fda is a cie References: <0FC98010-6811-4715-BD3B-AE8B9221C7BF@nokia.com> <20110706170323.GA28535@host1.jankratochvil.net> <4A77D598-9262-4A47-813D-0CD977E9DA68@nokia.com> Date: Thu, 07 Jul 2011 23:37:00 -0000 In-Reply-To: <4A77D598-9262-4A47-813D-0CD977E9DA68@nokia.com> (Fawzi Mohamed's message of "Thu, 7 Jul 2011 18:16:01 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00248.txt.bz2 >>>>> "Fawzi" == Fawzi Mohamed writes: Fawzi> 2011-07-07 Fawzi Mohamed Fawzi> * dwarf2-frame.c (decode_frame_entry, decode_frame_entry_1): Ensure Fawzi> that CIE pointer of an FDE really points to a CIE . Looks pretty good. Fawzi> + error (_("Found a CIE when not expecting it, broken eh_info")); Remove ", broken eh_info" here. Fawzi> + error (_("Found an FDE when not expecting it, broken eh_info.")); And here. The reason is that the error that is printed mentions .eh_frame, and I think that is sufficient. Fawzi> + warning (_("skipping .eh_frame info of %s: %s"),objfile->name, e.message); Line too long. Also, missing a space after the first "," -- but that is where you should split the line anyhow. Fawzi> + xfree(fde_table.entries); Space before the paren. Fawzi> + warning (_("skipping .debug_frame info of %s: %s"),objfile->name, e.message); Likewise. Fawzi> + xfree(fde_table.entries); Space. Fawzi> + { Fawzi> + xrealloc (fde_table.entries, Fawzi> + fde_table.num_entries * sizeof (fde_table.entries[0])); Wrong indentation for the xrealloc. I think it is weird not to use the result of the xrealloc call, even though we know it is just shrinking the buffer. Tom