From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18089 invoked by alias); 29 Apr 2012 15:16:16 -0000 Received: (qmail 18073 invoked by uid 22791); 29 Apr 2012 15:16:15 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 29 Apr 2012 15:15:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3TFFwYu008734 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 29 Apr 2012 11:15:59 -0400 Received: from psique (ovpn-112-35.phx2.redhat.com [10.3.112.35]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3TFFrWU023880; Sun, 29 Apr 2012 11:15:56 -0400 From: Sergio Durigan Junior To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: Regression for gdb.trace/backtrace.exp [Re: [PATCH 0/4 v3] Add support for static and SystemTap probes] References: <20120428203733.GA4485@host2.jankratochvil.net> <20120429091657.GA10077@host2.jankratochvil.net> X-URL: http://www.redhat.com Date: Sun, 29 Apr 2012 18:03:00 -0000 In-Reply-To: <20120429091657.GA10077@host2.jankratochvil.net> (Jan Kratochvil's message of "Sun, 29 Apr 2012 11:16:57 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg01066.txt.bz2 On Sunday, April 29 2012, Jan Kratochvil wrote: > On Sun, 29 Apr 2012 01:59:17 +0200, Sergio Durigan Junior wrote: >> I am committing it under the obvious rule. > > I do not see it in CVS anywhere, HEAD still crashes, OK for check-in, check it > in, please. You're right, I forgot to commit. How is that possible... >> --- gdb/ChangeLog 28 Apr 2012 23:22:11 -0000 1.14185 >> +++ gdb/ChangeLog 28 Apr 2012 23:58:31 -0000 >> @@ -1,3 +1,8 @@ >> +2012-04-28 Sergio Durigan Junior >> + >> + * tracepoint.c (start_tracing, stop_tracing): Checking for NULL >> + probes, fixing a regression inserted by my previous patchset. > > GNU Coding Standards paragraph starting with > There's no need to describe the full purpose of the changes > suggests more: > > Fix a regression inserted by my previous patchset. > * tracepoint.c (start_tracing, stop_tracing): Check for NULL probes. Addressed. Checked in: http://sourceware.org/ml/gdb-cvs/2012-04/msg00242.html Thanks, -- Sergio