Re: [RFA] Eliminate warnings about snprintf declaration

Ian Lance Taylor
2005-05-12T15:53:02Z

"Eli Zaretskii" <eliz@gnu.org> writes:

> > I believe you've got this logic reversed. You also don't want or need
> > the non-prototype - it's only needed for basename because basename
> > returns a pointer. How about this, based on the later examples in the
> > file:
>
> Okay. But I guess I should wait for approval by libiberty maintainers
> first.

I think Dan's comments are correct in that the patch needs to be
fixed. I, for one, would rather approve the final version of the
patch.

The general idea is fine.

Ian