Re: [RFA] Eliminate warnings about snprintf declaration

Daniel Jacobowitz
2005-05-12T20:51:07Z

On Thu, May 12, 2005 at 11:40:00PM +0300, Eli Zaretskii wrote:
> > Date: Thu, 12 May 2005 12:24:53 -0400
> > From: Daniel Jacobowitz <drow@false.org>
> > Cc: gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com
> >
> > The principle is that any project which uses libiberty, which wants
> > these definitions, must request them. Libiberty's config.h is included
> > by libiberty source files, before they include libiberty.h. GDB's
> > config.h is included by GDB source fles before they include
> > libiberty.h. So, if GDB needs the prototype, it is GDB's
> > responsibility to request it.
>
> So I need to add these functions to gdb/configure.ac _and_ to
> libiberty/configure.ac; got it. I will post a revised patch soon.
>
> Thanks for your patience.

Almost - you don't actually need them in libiberty/configure.ac, unless
you see warnings about them during the build of libiberty. To make GDB
-Werror happy, all you need is gdb/configure.ac and
include/libiberty.h.

Thank you for taking care of it!

--
Daniel Jacobowitz
CodeSourcery, LLC