Re: [RFA] Eliminate warnings about snprintf declaration

Eli Zaretskii
2005-05-12T15:42:24Z

> Date: Thu, 12 May 2005 11:08:04 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com
>
> I recommend copying the libiberty maintainers directly to get their
> attention.

Errr... who are they? libiberty/README says to send patches to
gcc-patches, which I did. What am I missing?

> Also, this isn't useful:
>
> > @@ -282,7 +282,7 @@
> > sysconf times sbrk gettimeofday ffs snprintf vsnprintf \
> > pstat_getstatic pstat_getdynamic sysmp getsysinfo table sysctl wait3 wait4 \
> > realpath canonicalize_file_name __fsetlocking)
> > - AC_CHECK_DECLS([basename, ffs, asprintf, vasprintf])
> > + AC_CHECK_DECLS([basename, ffs, asprintf, vasprintf, snprintf, vsnprintf])
> > AC_DEFINE(HAVE_SYS_ERRLIST, 1, [Define if you have the sys_errlist variable.])
> > AC_DEFINE(HAVE_SYS_NERR, 1, [Define if you have the sys_nerr variable.])
> > AC_DEFINE(HAVE_SYS_SIGLIST, 1, [Define if you have the sys_siglist variable.])
> > @@ -518,7 +518,7 @@
> > [AC_MSG_RESULT([no])])
> >
> > AC_CHECK_FUNCS($checkfuncs)
> > - AC_CHECK_DECLS([basename, ffs, asprintf, vasprintf])
> > + AC_CHECK_DECLS([basename, ffs, asprintf, vasprintf, snprintf, vsnprintf])
> > libiberty_NEED_DECLARATION(canonicalize_file_name)
> > fi
>
> That will only affect libiberty.h when building libiberty; it won't
> affect the users of libiberty.

Then how does one cause libiberty/configure to check for these
declarations and edit libiberty/config.h accordingly? I thought one
should modify configure.ac and the regenerate configure, no?

> I believe you've got this logic reversed. You also don't want or need
> the non-prototype - it's only needed for basename because basename
> returns a pointer. How about this, based on the later examples in the
> file:

Okay. But I guess I should wait for approval by libiberty maintainers
first.

Thanks.