From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6027 invoked by alias); 12 May 2005 15:53:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5945 invoked from network); 12 May 2005 15:52:59 -0000 Received: from unknown (205.217.158.180) by sourceware.org with QMTP; 12 May 2005 15:52:59 -0000 Received: (qmail 14107 invoked by uid 10); 12 May 2005 15:52:58 -0000 Received: (qmail 18947 invoked by uid 500); 12 May 2005 15:52:49 -0000 To: Eli Zaretskii Cc: gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com Subject: Re: [RFA] Eliminate warnings about snprintf declaration References: <01c4c990$Blat.v2.2.2$887ec720@zahav.net.il> <41994B9D.9080809@gnu.org> <01c55702$Blat.v2.4$d4764900@zahav.net.il> <20050512150804.GA1808@nevyn.them.org> <01c55708$Blat.v2.4$cfc9f040@zahav.net.il> From: Ian Lance Taylor Date: Thu, 12 May 2005 16:01:00 -0000 In-Reply-To: <01c55708$Blat.v2.4$cfc9f040@zahav.net.il> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-05/txt/msg00292.txt.bz2 "Eli Zaretskii" writes: > > I believe you've got this logic reversed. You also don't want or need > > the non-prototype - it's only needed for basename because basename > > returns a pointer. How about this, based on the later examples in the > > file: > > Okay. But I guess I should wait for approval by libiberty maintainers > first. I think Dan's comments are correct in that the patch needs to be fixed. I, for one, would rather approve the final version of the patch. The general idea is fine. Ian