From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17069 invoked by alias); 11 Feb 2009 01:46:06 -0000 Received: (qmail 16926 invoked by uid 22791); 11 Feb 2009 01:46:06 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Feb 2009 01:45:58 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n1B1hqix025512; Tue, 10 Feb 2009 20:43:52 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1B1hqlu001833; Tue, 10 Feb 2009 20:43:52 -0500 Received: from opsy.redhat.com (vpn-13-140.rdu.redhat.com [10.11.13.140]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n1B1hnRH018829; Tue, 10 Feb 2009 20:43:51 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 03797508250; Tue, 10 Feb 2009 18:43:47 -0700 (MST) To: Paul Pluzhnikov Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch] Fix a crash when displaying variables from shared library. References: <20090205030257.8A6073A6B7A@localhost> <8ac60eac0902061837p5885b812j8a26669e799702e1@mail.gmail.com> From: Tom Tromey Reply-To: Tom Tromey Date: Wed, 11 Feb 2009 01:46:00 -0000 In-Reply-To: <8ac60eac0902061837p5885b812j8a26669e799702e1@mail.gmail.com> (Paul Pluzhnikov's message of "Fri\, 6 Feb 2009 18\:37\:05 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00229.txt.bz2 >>>>> "Paul" == Paul Pluzhnikov writes: >> http://sourceware.org/ml/gdb-patches/2009-02/msg00002.html Paul> This turned out to be non-issue: disable_breakpoints_in_shlibs() Paul> is called just a couple of lines above, so by the time we get into Paul> disable_breakpoints_in_unloaded_shlib(), all of them already have Paul> loc-> shlib_disable == 1, and it remains silent. The comment in that function says that this is true for ELF shared libraries, but not others. But, it seems to me that notifying the observer here is the right thing to do -- otherwise this observer is unreliable. This patch is ok. Tom