From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24746 invoked by alias); 25 Mar 2009 00:31:19 -0000 Received: (qmail 24723 invoked by uid 22791); 25 Mar 2009 00:31:13 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Mar 2009 00:31:05 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2P0V1pK012288; Tue, 24 Mar 2009 20:31:01 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2P0Ut6k002428; Tue, 24 Mar 2009 20:30:55 -0400 Received: from opsy.redhat.com (vpn-12-180.rdu.redhat.com [10.11.12.180]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2P0Ux3D026220; Tue, 24 Mar 2009 20:31:00 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 1917E3785DA; Tue, 24 Mar 2009 18:30:58 -0600 (MDT) To: "Pierre Muller" Cc: Subject: Re: [RFC-version3] Fix completion bug for directories References: <000001c9a234$9e4486e0$dacd94a0$@u-strasbg.fr> From: Tom Tromey Reply-To: tromey@redhat.com Date: Wed, 25 Mar 2009 00:50:00 -0000 In-Reply-To: <000001c9a234$9e4486e0$dacd94a0$@u-strasbg.fr> (Pierre Muller's message of "Wed\, 11 Mar 2009 11\:32\:03 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00539.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> This is a new patch to fix the problem with completion on Pierre> directories. Oh, nice. This has bothered me a bit. I even dug into it once, but it looked like a pain. Thanks for posting URLs of the previous revisions of this patch. That helps a lot. One question I have is whether this works with the "complete" command. (I suspect it does not.) When I looked into this I sort of concluded that we would be better off not messing with readline's notions of word breaks, and furthermore that we'd be better off just adding filename completion directly to gdb. But, that was a lot more work than I wanted to do... I'd really like it to work with "complete", since that is what Emacs uses :-). But I suppose it is not really a requirement for the patch -- it remains an improvement even if it is not "perfect". Pierre> I do get some random success/failure differences Pierre> in Pierre> gdb.threads/schedlock.exp Pierre> or Pierre> gdb.threads/attach-into-signal.exp Pierre> but I understood from other emails that these are Pierre> non-deterministic tests that do fail/succeed more or less Pierre> randomly. Yes, that's correct. Pierre> Apparently, there are no listings of the header Pierre> dependencies in Makefile.in anymore, I suppose that Pierre> these are now generated automatically somehow now, is this right? Yes, dependency tracking is now automatic. Pierre> I didn't find anything in the generated Makefile, Pierre> how does that work? The dependencies themselves are stored in a .deps subdir. You need GNU make for this feature to be enabled. I can provide a fuller explanation if you want... A few nits on the patch: + if REASON is handle_brkchars: Capitalize: "If". There's a few of these. + depending gon the current command in line_buffer. Typo: s/gon/on/ When FOR_HELP is false, we will call a sub-command's completion - function. */ + function. It seems to me that this entire sentence ought to be deleted. This patch is ok with those changes. Thanks! Tom