From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2841 invoked by alias); 30 Mar 2009 23:01:10 -0000 Received: (qmail 2579 invoked by uid 22791); 30 Mar 2009 23:01:07 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Mar 2009 23:01:02 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2UN0xx6018259; Mon, 30 Mar 2009 19:00:59 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2UN0xZo026629; Mon, 30 Mar 2009 19:00:59 -0400 Received: from opsy.redhat.com (vpn-12-88.rdu.redhat.com [10.11.12.88]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2UN0w8Y016046; Mon, 30 Mar 2009 19:00:58 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 9AE9B3780FC; Mon, 30 Mar 2009 17:00:56 -0600 (MDT) To: gdb-patches@sourceware.org Cc: Mark Kettenis Subject: Re: [FYI] Inlining support, rough patch References: <20080613152754.GA4220@caradoc.them.org> <20080715192020.GB3094@caradoc.them.org> <200807172353.m6HNr1nY015884@brahms.sibelius.xs4all.nl> <20080718130308.GA19045@caradoc.them.org> <200807251446.m6PEkfwc027635@brahms.sibelius.xs4all.nl> <20080725174636.GB2433@caradoc.them.org> From: Tom Tromey Reply-To: tromey@redhat.com Date: Tue, 31 Mar 2009 03:06:00 -0000 In-Reply-To: <20080725174636.GB2433@caradoc.them.org> (Daniel Jacobowitz's message of "Fri\, 25 Jul 2008 13\:46\:36 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00697.txt.bz2 Resurrecting an old thread... Mark> It's the ID construction that I'm worried about. It is the very core Mark> of the unwinding code. I really think your diff violates the most Mark> fundamental principle of this bit of code and in that way, makes it Mark> much harder to understand it. Daniel> I don't understand what you mean when you say this makes the generic Daniel> code any harder to understand. Can you point to lines for me? [...] Daniel> If you can think of a way to do this that doesn't involve complicating Daniel> the generic unwind machinery - exactly what we're both trying to avoid Daniel> - I'll give it another shot. Mark, could you answer Daniel's questions? This patch has been in limbo since last July. I'd like to at least know what needs to be done to move forward on this. FWIW, we're shipping this in Archer. I think other organizations are shipping it as well. Debugging inlined functions nicely is a frequently requested feature; I answer questions about it on irc at least once a week. Tom