From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10340 invoked by alias); 10 Jun 2009 22:09:34 -0000 Received: (qmail 10330 invoked by uid 22791); 10 Jun 2009 22:09:34 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Jun 2009 22:09:25 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5AM7M5R016891; Wed, 10 Jun 2009 18:07:22 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5AM7Lb3005249; Wed, 10 Jun 2009 18:07:21 -0400 Received: from opsy.redhat.com (vpn-13-36.rdu.redhat.com [10.11.13.36]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5AM7KT4020091; Wed, 10 Jun 2009 18:07:21 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id CBD95C88051; Wed, 10 Jun 2009 16:07:19 -0600 (MDT) To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Move the multi-forks support to the generic multi-inferiors support. References: <200905310013.38916.pedro@codesourcery.com> <200906061707.21594.pedro@codesourcery.com> <200906090017.01168.pedro@codesourcery.com> From: Tom Tromey Reply-To: tromey@redhat.com Date: Wed, 10 Jun 2009 22:09:00 -0000 In-Reply-To: <200906090017.01168.pedro@codesourcery.com> (Pedro Alves's message of "Tue\, 9 Jun 2009 00\:17\:00 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00279.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Tom> In this case I think the patch is ok anyway -- an error in "info Tom> threads" does not, IMO, imply that we should propagate the mistake to Tom> other commands. Let me know what you think of this, I won't install Tom> the patch if you feel differently. Pedro> No, I agree with you. Thanks. I'm am going to commit this shortly. Pedro> My only concern is that the PID column may end up being Pedro> the wrong name for the target-id, due to targets that don't have a real Pedro> notion of PID. I was planning of making that column's value print Pedro> something like target_pid_to_str (pid_to_ptid (PID)), just like the Pedro> corresponding column in info threads. I was hoping that when Pedro> we'd get to name the columns in "info threads" we'd come up with Pedro> a nice name for it. :-) I think we can change the column headers, as shown by the CLI (and not MI? I am not certain) at some later date, just by changing the ui_out_table_header calls. So I'm not too worried. Tom