From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Richard Guenther <rguenther@suse.de>
Subject: Re: [patch] Fix find_separate_debug_file buffer overrun [Re: gdb crash during read of separate debuginfo]
Date: Mon, 03 Aug 2009 16:46:00 -0000 [thread overview]
Message-ID: <m3y6q0luad.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090802211036.GA28064@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sun\, 2 Aug 2009 23\:10\:37 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Richard> We experienced crashes when running gdb inside out installation
Richard> system which has /usr symlinked to some location beyond /mnt.
Richard> The issue is that the code doesn't deal with the case that
Richard> the result of lrealpath is longer than its argument.
Jan> thanks, posting updated patch for FSF GDB as it is not a Fedora regression.
Jan> This attached patch has not been reviewed by Richard Guenther.
Jan> 2009-08-02 Richard Guenther <rguenther@suse.de>
Jan> Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Fix memory corruption on reread of file through a symbolic link.
Jan> * symfile.c (find_separate_debug_file): Initialize CANON_NAME earlier.
Jan> Allocate DEBUGFILE with length based on CANON_NAME. Free CANON_NAME on
Jan> all the return paths.
This looks good to me.
Ok.
Jan> I do not push much to get the testcase accepted.
Is there something in particular you think is wrong with it? It looks
ok to me, but your comment makes me wonder what subtlety I missed.
Tom
next prev parent reply other threads:[~2009-08-03 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LNX.2.00.0908021137300.16347@zhemvz.fhfr.qr>
2009-08-02 21:11 ` Jan Kratochvil
2009-08-03 16:46 ` Tom Tromey [this message]
2009-08-03 17:13 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y6q0luad.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox