From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: FYI: minor simplification in add_psymbol_to_bcache
Date: Wed, 04 Nov 2009 19:16:00 -0000 [thread overview]
Message-ID: <m3y6mm2j90.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20091103202058.GA23081@caradoc.them.org> (Daniel Jacobowitz's message of "Tue, 3 Nov 2009 15:20:58 -0500")
>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:
Tom> First, it removes the gratuitous use of a 'static' local variable.
Daniel> It adds a memset... if you assume that this is a hot function, then it
Daniel> was probably avoided on purpose. On the other hand, the way it's
Daniel> implemented is quite dodgy; there will be bogus padding if
Daniel> sizeof (long) != sizeof (CORE_ADDR) and you alternate adding symbols
Daniel> with VAL and COREADDR set.
TBH I was not thinking too soundly, I suppose, when I nuked this. I
think your point is a good one. If you'd prefer, I will leave this
static and just zero out that field.
Tom
next prev parent reply other threads:[~2009-11-04 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 20:10 Tom Tromey
2009-11-03 20:21 ` Daniel Jacobowitz
2009-11-04 19:16 ` Tom Tromey [this message]
2009-11-05 20:03 ` Daniel Jacobowitz
2009-11-05 22:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y6mm2j90.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox