Re: [patch] Add namespace aliasing support.

Tom Tromey
2010-02-02T19:23:16Z

>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:

Sami> 2010-02-01 Sami Wagiaalla <swagiaal@redhat.com>
Sami> * cp-support.h: Added char* alias element to using_direct data
Sami> struct.

I noticed that an earlier ChangeLog entry of yours (in testsuite) had 4
leading spaces rather than a tab. This one seems to have the same
problem, at least if you cut-and-pasted it; please fix before
committing.

Also, put the PR number into the ChangeLog entry and the commit. You
can see the existing ChangeLog for some examples of the formatting.
Putting it in the ChangeLog just makes the entry a little more useful;
putting it into the commit message will make some info about the commit
be automatically appended to the PR.

Sami> + scope. If ALIAS is an empty string then the namespace is known by its
Sami> + original name.

This should say something like: If ALIAS is not null, then ...

Sami> + of the list. ALIAS is set to a non empty string if the imported namespace
Sami> + has been aliased.

Likewise.

This patch is ok with those things fixed. Thanks.

Tom