From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24586 invoked by alias); 3 Feb 2010 22:09:45 -0000 Received: (qmail 24578 invoked by uid 22791); 3 Feb 2010 22:09:45 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Feb 2010 22:09:41 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o13M9R3v006134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 3 Feb 2010 17:09:28 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o13M9R4r029427; Wed, 3 Feb 2010 17:09:27 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o13M9Qwo015669; Wed, 3 Feb 2010 17:09:26 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 977C6378181; Wed, 3 Feb 2010 15:09:25 -0700 (MST) From: Tom Tromey To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Remove deprecated_sym_private References: <20100203160830.GA83064@ulanbator.act-europe.fr> Reply-To: tromey@redhat.com Date: Wed, 03 Feb 2010 22:09:00 -0000 In-Reply-To: <20100203160830.GA83064@ulanbator.act-europe.fr> (Tristan Gingold's message of "Wed, 3 Feb 2010 17:08:30 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00095.txt.bz2 >>>>> "Tristan" == Tristan Gingold writes: Tristan> I wrote a patch that remove deprecated_sym_private, but I am Tristan> not sure that it is worth applying it: not sure this is a real Tristan> improvment, and I think that the private data_key could be Tristan> shared among all symbol readers. FWIW I agree with Daniel. [ objfiles.h ] Tristan> /* Per objfile data-pointers required by other GDB modules. */ Tristan> /* FIXME: kettenis/20030711: This mechanism could replace Tristan> deprecated_sym_stab_info and deprecated_sym_private I think this FIXME is half-obsolete now; deprecated_sym_stab_info remains. Tom