From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5074 invoked by alias); 7 Apr 2010 19:47:18 -0000 Received: (qmail 5064 invoked by uid 22791); 7 Apr 2010 19:47:17 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Apr 2010 19:47:13 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o37JlBFw000687 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Apr 2010 15:47:11 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o37JlAbJ017750; Wed, 7 Apr 2010 15:47:10 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o37Jl9aq029163; Wed, 7 Apr 2010 15:47:10 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 8D80C379851; Wed, 7 Apr 2010 13:47:09 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix deadlock on looped solib list References: <20100403092301.GA21485@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Wed, 07 Apr 2010 19:47:00 -0000 In-Reply-To: <20100403092301.GA21485@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat, 3 Apr 2010 11:23:01 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00153.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> While some simple n^2 check or maximal allowed libraries list could Jan> be more simple remembering Google was patching GDB for very large Jan> solib lists. I don't remember hearing about this... anybody know why this isn't in the FSF GDB? Jan> gdb/ Jan> 2010-04-03 Jan Kratochvil Jan> Fix deadlock on looped list of loaded shared objects. Jan> * arch-utils.c (core_addr_hash, core_addr_eq): New. Jan> * arch-utils.h: Include hashtab.h. Jan> (core_addr_hash, core_addr_eq): New prototypes. Jan> * defs.h: Include hashtab.h. Jan> (make_cleanup_htab_delete): New prototype. Jan> * solib-svr4.c: Include arch-utils.h. Jan> (svr4_current_sos): New variables lm_obstack, lm_hash, outer_chain, Jan> initialize them, call outer_chain do_cleanups at the bottom. Move new Jan> and old_chain initializations after a new duplicity check of LM using Jan> new variable lm_slot. Jan> * utils.c (do_htab_delete_cleanup, make_cleanup_htab_delete): New. This is ok. Thanks. Tom