From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30455 invoked by alias); 13 Jul 2010 16:28:14 -0000 Received: (qmail 30440 invoked by uid 22791); 13 Jul 2010 16:28:13 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Jul 2010 16:28:04 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6DGRkQs025071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 13 Jul 2010 12:27:46 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6DGRjeO022582; Tue, 13 Jul 2010 12:27:45 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6DGRiun020968; Tue, 13 Jul 2010 12:27:45 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 519FE3782A3; Tue, 13 Jul 2010 10:27:44 -0600 (MDT) From: Tom Tromey To: Jerome Guitton Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Nullified garbage-collected global variables References: <1278948088-15391-1-git-send-email-guitton@adacore.com> Date: Tue, 13 Jul 2010 16:28:00 -0000 In-Reply-To: <1278948088-15391-1-git-send-email-guitton@adacore.com> (Jerome Guitton's message of "Mon, 12 Jul 2010 17:21:28 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00221.txt.bz2 >>>>> "Jerome" == Jerome Guitton writes: Jerome> * dwarf2read.c (add_partial_symbol): Do not add a global variable if Jerome> its adress is null. Add comment to explain why. I am not totally sure about this. The patch itself looks reasonable, but I have a couple of questions. Do you need to apply the same treatment to full symbols? What happens if the psymtab is expanded for some other reason and a full symbol of this sort is then created? Or is that already impossible? What about has_section_at_zero? Tom