Re: [patch] Add visible flag to breakpoints.

[Phil Muldoon <pmuldoon@redhat.com>]

Pedro Alves <pedro@codesourcery.com> writes:


> Can you give an example of a use case where you would want to be
> able to show/hide breakpoints from the user _after_ they've been
> created?  This looks like something that has potential to confuse
> users.  E.g., "my gdb sometimes creates breakpoint 10 and then
> skips to create breakpoint 20, what gives?  where are 11-19?".

I don't have one.  I purely created the API for scripting utility, I have no
objections whatsoever to removing the setter.

> If toggling the new visible attribute isn't really necessary,
> did you consider instead a new "internal-or-not-internal" flag to
> the breakpoint constructor?  An internal breakpoint is just a
> breakpoint with number < 0, and as such is not visible to
> the user.

I replied to Dan on this.  Could I ask you to read my reply there?
Thanks!

> As is, your patch does not consider for example the
> "delete" command --- it wipes all non-internal breakpoints, even
> if hidden!  That's potential for breaking the python client
> code that creates and manages such breakpoints.  I suggest
> you go through breakpoint.c and inspect all checks against
> b->number < 0 or b->number >= 0.

'delete breakpoints' have always been likely to confuse python scripts
that set breakpoints (now, and in this new visibility patch).  I did the
checks you mentioned.  I'm just not sure how to work around it given my
objections to using internal breakpoints.  What do you think?

>
>>         (create_new_breakpoint): Renamed from create_new_breakpoint.  Add
>>         visible parameter.
>
> Renamed from create_breakpoint.
>
>> +# Test invisible breakpooints.


Thanks

Cheers,

Phil