From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2532 invoked by alias); 24 Feb 2011 19:22:48 -0000 Received: (qmail 2524 invoked by uid 22791); 24 Feb 2011 19:22:48 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_WT,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Feb 2011 19:22:43 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1OJMKub002445 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 24 Feb 2011 14:22:20 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p1OJMKdb006650; Thu, 24 Feb 2011 14:22:20 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1OJMJxr022714; Thu, 24 Feb 2011 14:22:19 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 4F2A0378388; Thu, 24 Feb 2011 12:22:19 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/18] New module remote-wtx-utils References: <1298569763-18784-1-git-send-email-brobecker@adacore.com> <1298569763-18784-7-git-send-email-brobecker@adacore.com> Date: Thu, 24 Feb 2011 19:26:00 -0000 In-Reply-To: <1298569763-18784-7-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 24 Feb 2011 12:49:11 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00728.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> I rewrote a bit the routines to depend on two functions gdb_dlopen and Joel> gdb_dlsym which we could isolate in its own gdb_dlfcn.h/c if we wanted to. The problem with putting stuff like this into a place like remote-wtx-utils.c is that if somebody does need it later, they probably will not know it exists, and will reimplement. This happens with some of the CLI utility functions. I think it is somewhat better to pick a generic spot to put the new functions, and just make the most convenient failure choice -- like, if they aren't available, have them internal_error or whatever else is convenient and unambiguous. That said, it doesn't matter hugely to me. Joel> +void * Joel> +load_shared_lib (char *lib_name) I think the argument could be const. Joel> +void * Joel> +get_symbol_from_shared_lib (void *handle, char *symbol) Likewise. Tom