From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18229 invoked by alias); 22 Jun 2011 16:06:53 -0000 Received: (qmail 18221 invoked by uid 22791); 22 Jun 2011 16:06:52 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Jun 2011 16:06:37 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5MG6atI029841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 Jun 2011 12:06:36 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p5MG6ZZI022461; Wed, 22 Jun 2011 12:06:36 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p5MG6Yg0010018; Wed, 22 Jun 2011 12:06:35 -0400 From: Tom Tromey To: Marek Polacek Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] gdb.mi/mi-var-display.exp: fix racy tests (PR testsuite/12649) References: <4E00A31B.6030500@redhat.com> Date: Wed, 22 Jun 2011 16:06:00 -0000 In-Reply-To: <4E00A31B.6030500@redhat.com> (Marek Polacek's message of "Tue, 21 Jun 2011 15:56:43 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00314.txt.bz2 >>>>> "Marek" == Marek Polacek writes: Marek> 2011-06-21 Marek Polacek Marek> * gdb.mi/mi-var-display.exp: Replace gdb_test_multiple with mi_gdb_test. One nit. Marek> +if ![mi_gdb_test "p/x \$fp" ".*($hex).*\\^done" "Xprint FP register"] { Marek> + set fp $expect_out(3,string) Too much indentation here. Ok with that fix; plus the fix from your follow-up email. Tom