From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12285 invoked by alias); 20 Jul 2011 14:59:02 -0000 Received: (qmail 12270 invoked by uid 22791); 20 Jul 2011 14:59:01 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 14:58:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6KEwl0u014424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Jul 2011 10:58:47 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6KEwlrE030278; Wed, 20 Jul 2011 10:58:47 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6KEwjUZ029720; Wed, 20 Jul 2011 10:58:46 -0400 From: Tom Tromey To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Prompt memory management/cleanups References: Date: Wed, 20 Jul 2011 15:05:00 -0000 In-Reply-To: (Phil Muldoon's message of "Wed, 20 Jul 2011 14:05:11 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00530.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> While working on the Python patch to allow prompt substitution in Phil> Python, I noticed that in some cases prompts were leaking memory. In Phil> several cases, scenarios like: PROMPT (0) = xstrdup(someprompt), did not Phil> xfree the prompt first. I decided to use functions calls to replace Phil> access to PROMPT/SUFFIX/PREFIX so that memory management can be Phil> performed centrally. Attached is a patch. I'd appreciate comments on Phil> this; the testsuite shows no regressions, but my knowledge of the prompt Phil> area of GDB is about three days old. I'd especially like comments on the Phil> acceptance on NULL in the set_prompt/prefix/suffix functions. Pop/push Phil> prompt uses different prompt levels and requires that, after use, they Phil> are cleaned. It normally just does this with xfree. I'm unsure if my Phil> API for that scenario is preferable. The patch seems fine, but I have a few questions. Does anything ever set the prefix or suffix to a non-empty value? I couldn't find an instance. So how about just removing all this stuff instead? Do we still need the PROMPT, PREFIX, and SUFFIX defines in event-top.h? Tom