From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13835 invoked by alias); 16 Jan 2012 19:38:06 -0000 Received: (qmail 13827 invoked by uid 22791); 16 Jan 2012 19:38:05 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Jan 2012 19:37:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0GJbqKP029615 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Jan 2012 14:37:52 -0500 Received: from psique ([10.3.112.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0GJbmDn010819; Mon, 16 Jan 2012 14:37:50 -0500 From: Sergio Durigan Junior To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [RFC 1/8] Language independent bits References: <20120115203420.GA18901@host2.jankratochvil.net> X-URL: http://www.redhat.com Date: Mon, 16 Jan 2012 19:39:00 -0000 In-Reply-To: (Tom Tromey's message of "Mon, 16 Jan 2012 10:46:05 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00572.txt.bz2 On Monday, January 16 2012, Tom Tromey wrote: >>>>>> "Jan" == Jan Kratochvil writes: > >>> + int expout_size; > Jan> Memory object size does not fit into `int', it should be `size_t'. > > I agree, but I think that mixing different kinds of refactorings into > one patch can be unnecessarily complicated and confusing. The 'int' is > already there today. I already replaced `int' by `size_t'. Do you want me to revert the change?