Re: [patch] Create cleanups.[ch]

Pedro Alves
2012-04-16T20:41:10Z

On 04/16/2012 09:06 PM, Tom Tromey wrote:

>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> This made me notice that make_my_cleanup was unexported, and made
> Pedro> static in this patch, but note how that goes by mostly unnoticed
> Pedro> (at least it was to me on first sight).
>
> I have long had the impression, based solely on reading the cleanup
> code, that cleanups were intended to be used in other ways and then
> never were. E.g., unchaining cleanups and attaching them to some other
> object (say, replacing the existing objfile data destructor methods)
> seems doable, but AFAIK is not ever done.

Makes sense. It never occurred to me.

> If anything is unused at this point, I'd say we can just delete it.

Sorry if it sounded like I didn't agree with that; I definitely do.
I only meant that it'd have preferred such change as a separate change.
It's okay with me to not bother now.

--
Pedro Alves