From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23182 invoked by alias); 12 Oct 2014 19:50:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23159 invoked by uid 89); 12 Oct 2014 19:50:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f45.google.com Received: from mail-pa0-f45.google.com (HELO mail-pa0-f45.google.com) (209.85.220.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 12 Oct 2014 19:50:26 +0000 Received: by mail-pa0-f45.google.com with SMTP id rd3so4711498pab.32 for ; Sun, 12 Oct 2014 12:50:24 -0700 (PDT) X-Received: by 10.67.23.13 with SMTP id hw13mr19369176pad.69.1413143424337; Sun, 12 Oct 2014 12:50:24 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50]) by mx.google.com with ESMTPSA id e4sm455401pdp.37.2014.10.12.12.50.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Oct 2014 12:50:23 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: "gdb-patches\@sourceware.org ml" Subject: Re: [RFA 0/9] Explicit locations v2 - Introduction References: <536BC52D.80800@redhat.com> Date: Sun, 12 Oct 2014 19:50:00 -0000 In-Reply-To: <536BC52D.80800@redhat.com> (Keith Seitz's message of "Thu, 08 May 2014 10:55:57 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00300.txt.bz2 Keith Seitz writes: > Hi, > > I would like to resurrect this project from last year. > > This patch series introduces "explicit" locations, which allow users > to explicitly specify location attributes when setting > breakpoints. This feature can be especially handy, for example, when > an application defines multiple functions of the same name: > > (gdb) break -source file1.c -function multiple_symbols_with_this_name > > In this case, gdb will only attempt to set a breakpoint in the given > source file. If the given symbol is not defined in the file, gdb will > do the usual pending breakpoint query. > > This revision is largely the same as the one I posted last year with > one notable change: I have implemented probe locations. > > Consequently, this API change now supports the following "event > locations": linespec, address (formerly "*EXPR"), explicit, and probe. > > I have attempted to break up the patch to assist review. The intent is > to apply all patches approved. Nonetheless, each patch may be applied > sequentially and should not cause any build failures or introduce any > test suite regressions. > > I have tested each patch on both x86_64 native and native-gdbserver. Hi. I've read the patch set twice more now, including reading the patched code. [That's what weekends are for, right? :-)] I've got a high level question, and a few nits. Before I impose submitting another version of the patch I'm hoping we can get the remaining high level issues resolved first. I think I better understand the things you have to go through to parse linespecs, but there's still something here that needs more work. I think it'll just involve a bit of API tweaking, so nothing major. I'll leave the discussion to the email with the patch. Thanks for the effort so far! Sorry this is taking awhile to review.