From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-125532-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 103468 invoked by alias); 23 Aug 2015 03:59:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 103449 invoked by uid 89); 23 Aug 2015 03:59:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-pa0-f45.google.com
Received: from mail-pa0-f45.google.com (HELO mail-pa0-f45.google.com) (209.85.220.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 23 Aug 2015 03:59:38 +0000
Received: by padfo6 with SMTP id fo6so34943334pad.1        for <gdb-patches@sourceware.org>; Sat, 22 Aug 2015 20:59:36 -0700 (PDT)
X-Received: by 10.66.65.205 with SMTP id z13mr32060790pas.26.1440302376761;        Sat, 22 Aug 2015 20:59:36 -0700 (PDT)
Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53])        by smtp.gmail.com with ESMTPSA id d13sm12644521pbu.51.2015.08.22.20.59.35        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Sat, 22 Aug 2015 20:59:36 -0700 (PDT)
From: Doug Evans <xdje42@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 08/19] Implement completion limiting for signal_completer.
References: <20150806191404.32159.50755.stgit@valrhona.uglyboxes.com>	<20150806191705.32159.6734.stgit@valrhona.uglyboxes.com>
Date: Sun, 23 Aug 2015 03:59:00 -0000
In-Reply-To: <20150806191705.32159.6734.stgit@valrhona.uglyboxes.com> (Keith	Seitz's message of "Thu, 06 Aug 2015 12:17:53 -0700")
Message-ID: <m3y4h2hd03.fsf@sspiff.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2015-08/txt/msg00647.txt.bz2

Keith Seitz <keiths@redhat.com> writes:
> There are no revisions in this version.
>
> ---
>
> This patch converts signal_completer to use add_completion
> and adds some tests to cover this new behavior.
>
> gdb/ChangeLog
>
> 	* completer.c (signal_completer): Use add_completion.
>
> gdb/testsuite/ChangeLog
>
> 	* gdb.base/completion.exp: Add completion limiting tests
> 	for "handle signal".

LGTM