Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Philipp Rudo <prudo@linux.vnet.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
	       Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [PATCH] s390: Fix gdb.base/all-architectures.exp with --enable-targets=all
Date: Tue, 30 Jan 2018 16:12:00 -0000	[thread overview]
Message-ID: <m3y3kfjph2.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <20180125100828.7599-2-prudo@linux.vnet.ibm.com> (Philipp Rudo's	message of "Thu, 25 Jan 2018 11:08:28 +0100")

On Thu, Jan 25 2018, Philipp Rudo wrote:

> gdb/ChangeLog:
>
> 	* s390-linux-tdep.c: Move includes for features/s390-linux32.c and
> 	features/s390x-linux64.c to s390-tdep.c.
> 	(_initialize_s390_linux_tdep): Move initializaion of tdesc
> 	s390_linux32 and s390x_linux64 to s390-tdep.c.
> 	(s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set default
> 	tdesc.
> 	* s390-tdep.c: Add include of features/s390-linux32.c and
> 	features/s390x-linux64.c.
> 	(s390_tdesc_valid): Add check for tdesc_has_registers.
> 	(s390_gdbarch_init): Make sure there is always an valid tdesc.
> 	(_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
> 	tdesc_s390x_linux64.
> 	* s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
> 	tdesc_s390x_linux64 to ...
> 	* s390-tdep.h: ... here.

Looks OK.  Pushed with minor spelling fixes as c81e88797907f.

--
Andreas


      reply	other threads:[~2018-01-30 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25 10:08 Philipp Rudo
2018-01-25 10:08 ` Philipp Rudo
2018-01-30 16:12   ` Andreas Arnez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y3kfjph2.fsf@oc1027705133.ibm.com \
    --to=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=prudo@linux.vnet.ibm.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox