From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7078 invoked by alias); 4 Jan 2007 00:04:55 -0000 Received: (qmail 7070 invoked by uid 22791); 4 Jan 2007 00:04:54 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Jan 2007 00:04:47 +0000 Received: (qmail 13681 invoked from network); 4 Jan 2007 00:04:46 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 Jan 2007 00:04:46 -0000 To: gdb-patches@sourceware.org Subject: RFA: update name of glibc PLT fixup function From: Jim Blandy Date: Thu, 04 Jan 2007 00:04:00 -0000 Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00096.txt.bz2 No regressions on FC6 IA-32. But there are also no reports that this is necessary. Andreas Schwab simply pointed out that ld-linux.so doesn't use 'fixup' any more, so I thought I'd be pro-active. Okay to commit? gdb/ChangeLog: 2007-01-03 Jim Blandy * glibc-tdep.c (glibc_skip_solib_resolver): Look for '_dl_fixup', then plain 'fixup'. Index: gdb/glibc-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/glibc-tdep.c,v retrieving revision 1.3 diff -u -r1.3 glibc-tdep.c --- gdb/glibc-tdep.c 17 Dec 2005 22:34:00 -0000 1.3 +++ gdb/glibc-tdep.c 4 Jan 2007 00:02:22 -0000 @@ -90,8 +90,13 @@ if (resolver) { + /* The dynamic linker began using this name in early 2005. */ struct minimal_symbol *fixup - = lookup_minimal_symbol ("fixup", NULL, objfile); + = lookup_minimal_symbol ("_dl_fixup", NULL, objfile); + + /* This is the name used in older versions. */ + if (! fixup) + fixup = lookup_minimal_symbol ("fixup", NULL, objfile); if (fixup && SYMBOL_VALUE_ADDRESS (fixup) == pc) return frame_pc_unwind (get_current_frame ());