From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2315 invoked by alias); 15 Jan 2008 17:06:27 -0000 Received: (qmail 2307 invoked by uid 22791); 15 Jan 2008 17:06:27 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Jan 2008 17:06:00 +0000 Received: (qmail 22292 invoked from network); 15 Jan 2008 17:05:58 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Jan 2008 17:05:58 -0000 To: Michael Snyder Cc: Rob Quill , gdb-patches@sourceware.org Subject: Re: New scope checking patch References: <1200352032.3263.20.camel@localhost.localdomain> From: Jim Blandy Date: Tue, 15 Jan 2008 17:06:00 -0000 In-Reply-To: <1200352032.3263.20.camel@localhost.localdomain> (Michael Snyder's message of "Mon, 14 Jan 2008 15:07:12 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00352.txt.bz2 Michael Snyder writes: > On Fri, 2008-01-11 at 14:50 -0800, Jim Blandy wrote: > >> Use 'cvs diff -u' or 'cvs diff -c' to produce unified or context >> diffs. Unified diffs seem to be the more widely preferred form these >> days. All patches posted to this list (or pretty much to any other >> open source list) should be in unified or context diff form. > > In a previous thread, we sort of reached (or approached) > a loose consensus that "diff -up" is preferred. > > You didn't mention -p, but folks didn't like -p without the -u > anyways... Sounds good to me.