From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29940 invoked by alias); 9 Nov 2009 17:48:29 -0000 Received: (qmail 29932 invoked by uid 22791); 9 Nov 2009 17:48:29 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 17:48:24 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HmMsM017250; Mon, 9 Nov 2009 12:48:22 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HmIPv012824; Mon, 9 Nov 2009 12:48:20 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HmH1H009095; Mon, 9 Nov 2009 12:48:18 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 0B53A37815E; Mon, 9 Nov 2009 10:48:17 -0700 (MST) From: Tom Tromey To: Michael Snyder Cc: Hui Zhu , "gdb-patches\@sourceware.org" Subject: Re: [RFA] Fix hw watchpoints in process record. References: <4AECE12F.3000704@vmware.com> <4AF31C1F.2000405@vmware.com> Reply-To: tromey@redhat.com Date: Mon, 09 Nov 2009 17:48:00 -0000 In-Reply-To: <4AF31C1F.2000405@vmware.com> (Michael Snyder's message of "Thu, 05 Nov 2009 10:40:31 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00148.txt.bz2 >>>>> "Michael" == Michael Snyder writes: Michael> static int Michael> -watchpoint_check (void *p) Michael> +watchpoint_check_1 (void *p, struct value **new_valp) I think the first argument should be of type struct breakpoint *. All the calls to this function seem to pass in a breakpoint, and AFAICT there is nothing requiring this code not to use the proper type. Tom