From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21675 invoked by alias); 17 Feb 2010 18:47:41 -0000 Received: (qmail 21665 invoked by uid 22791); 17 Feb 2010 18:47:40 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Feb 2010 18:47:34 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1HIlWaf002163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Feb 2010 13:47:32 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1HIlVre016093; Wed, 17 Feb 2010 13:47:31 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o1HIlUHv010057; Wed, 17 Feb 2010 13:47:30 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id E4603379956; Wed, 17 Feb 2010 11:47:29 -0700 (MST) From: Tom Tromey To: =?utf-8?Q?S=C3=A9rgio?= Durigan =?utf-8?Q?J=C3=BAnior?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Function-like cast notation support References: <201002171345.36988.sergiodj@redhat.com> Reply-To: tromey@redhat.com Date: Wed, 17 Feb 2010 18:47:00 -0000 In-Reply-To: <201002171345.36988.sergiodj@redhat.com> (=?utf-8?Q?=22S?= =?utf-8?Q?=C3=A9rgio?= Durigan =?utf-8?Q?J=C3=BAnior=22's?= message of "Wed, 17 Feb 2010 13:45:29 -0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00433.txt.bz2 >>>>> "S=C3=A9rgio" =3D=3D S=C3=A9rgio Durigan J=C3=BAnior writes: S=C3=A9rgio> The following patch adds support for function-like cast notati= on S=C3=A9rgio> on GDB. This looks good. It could use a NEWS entry. I suggest waiting until my NEWS change goes in, then adding it to the C++ improvements section. S=C3=A9rgio> Currently it only works for primitive data type (int, S=C3=A9rgio> char, double, etc), but I intend to send another patch soon th= at S=C3=A9rgio> will implement this feature for classes as well. Hmm, you seem to have implemented this already... S=C3=A9rgio> +typebase_single S=C3=A9rgio> : TYPENAME S=C3=A9rgio> { $$ =3D $1.type; } ... because the lexer can return TYPENAME for a class name. S=C3=A9rgio> + { "void" "void" "'a'" "void" } I didn't realize this was supposed to work... learn something every day :-) This patch is ok. Thanks. For future reference, it is worth noting in the email how and whether you regression tested it. I assume that everybody does this, but it is nice to be explicit about it. At least in my case, this occasionally helps me realize that I forgot. Tom