From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18393 invoked by alias); 30 Apr 2010 18:54:22 -0000 Received: (qmail 18325 invoked by uid 22791); 30 Apr 2010 18:54:21 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Apr 2010 18:54:15 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3UIsEAg012555 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Apr 2010 14:54:14 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3UIsDxe012367; Fri, 30 Apr 2010 14:54:14 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3UIsC0R029483; Fri, 30 Apr 2010 14:54:13 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 788FD3795F9; Fri, 30 Apr 2010 12:54:12 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Sami Wagiaalla Subject: Re: [patch 2/3] Extend C++ import to support renaming even declarations References: <20100430181648.GB19190@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Fri, 30 Apr 2010 18:54:00 -0000 In-Reply-To: <20100430181648.GB19190@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Fri, 30 Apr 2010 20:16:48 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg01013.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> Therefore this patch implements the last case. It does not affect existing Jan> C++ functionality in the other 3 cases. Jan> 2010-04-30 Jan Kratochvil Jan> * cp-namespace.c (cp_lookup_symbol_imports): Support ALIAS for the Jan> CURRENT-> DECLARATION case. Please also update the documentation for struct using_direct to mention this case. Right now the comment there indicates that alias==NULL in all other cases. This patch is ok with that change. I wonder why the fields of using_direct are not const char *. Tom