From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9232 invoked by alias); 27 May 2010 21:24:48 -0000 Received: (qmail 9224 invoked by uid 22791); 27 May 2010 21:24:47 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 May 2010 21:24:40 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4RLOdfR023864 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 May 2010 17:24:39 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4RLOckI004256; Thu, 27 May 2010 17:24:38 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o4RLObc3001420; Thu, 27 May 2010 17:24:38 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 8CD313780A5; Thu, 27 May 2010 15:24:37 -0600 (MDT) From: Tom Tromey To: Sergio Durigan Junior Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [PATCH] Forbid watchpoint on a constant value References: <201005181418.24324.sergiodj@redhat.com> <201005200210.27056.sergiodj@redhat.com> <20100520152941.GA19950@host0.dyn.jankratochvil.net> <201005201313.02076.sergiodj@redhat.com> Reply-To: tromey@redhat.com Date: Thu, 27 May 2010 21:54:00 -0000 In-Reply-To: <201005201313.02076.sergiodj@redhat.com> (Sergio Durigan Junior's message of "Thu, 20 May 2010 13:13:01 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00667.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: >> > + case UNOP_LOWER: >> > + case UNOP_UPPER: >> > + case UNOP_LENGTH: >> > + case UNOP_CARD: >> > + case UNOP_CHMAX: >> > + case UNOP_CHMIN: Jan> I do not see implemented evaluation of these, also their processing should Jan> have been probably moved to ... the already deleted Chill support files. Sergio> Likewise. I think the best thing to do is, if you run into some object (function, variable, constant, type) that is truly unused in gdb, then submit a separate patch to remove all remaining mentions of it. Tom