From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16170 invoked by alias); 22 Oct 2010 21:37:43 -0000 Received: (qmail 16050 invoked by uid 22791); 22 Oct 2010 21:37:42 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Oct 2010 21:37:36 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9MLbM98021257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Oct 2010 17:37:22 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o9MLbK73030791; Fri, 22 Oct 2010 17:37:20 -0400 From: Phil Muldoon To: Eli Zaretskii Cc: tromey@redhat.com, pedro@codesourcery.com, gdb-patches@sourceware.org, dan@codesourcery.com Subject: Re: [patch] Add visible flag to breakpoints. References: <201010081435.15174.pedro@codesourcery.com> <201010162003.41609.pedro@codesourcery.com> <83aam59aot.fsf@gnu.org> Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Fri, 22 Oct 2010 21:37:00 -0000 In-Reply-To: <83aam59aot.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Oct 2010 23:31:14 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00356.txt.bz2 Eli Zaretskii writes: >> From: Phil Muldoon >> Cc: Pedro Alves , gdb-patches@sourceware.org, dan@codesourcery.com >> Date: Fri, 22 Oct 2010 22:05:30 +0100 >> >> I decided to add internal watchpoint support. I've also added the other >> changes requested. >> >> OK? > > Thanks. > >> -/* Set a breakpoint. This function is shared between CLI and MI >> +/* Set a breakpoint. This function is shared between CLI and MI > > Why did you need to remove one of the two spaces between these > sentences? I didn't, this was an error. Thanks for catching. > >> functions for setting a breakpoint. This function has two major >> modes of operations, selected by the PARSE_CONDITION_AND_THREAD >> parameter. If non-zero, the function will parse arg, extracting >> breakpoint location, address and thread. Otherwise, ARG is just the >> location of breakpoint, with condition and thread specified by the >> - COND_STRING and THREAD parameters. Returns true if any breakpoint >> - was created; false otherwise. */ >> - >> + COND_STRING and THREAD parameters. If INTERNAL is non-zero, the >> + breakpoint number will be allocated from the internal breakpoint >> + count. Returns true if any breakpoint was created; false > ^^^ > And here you have 3 instead of 2. Thanks >> +@code{maint info breakpoints} command). The optional @var{wp_class} >> argument defines the class of watchpoint to create, if @var{type} is >> defined as @code{BP_WATCHPOINT}. > > "if @var{type} is @code{BP_WATCHPOINT}" is simpler and more clear, IMO. Thanks. >> +@defivar Breakpoint visible >> +This attribute holds the breakpoint's visibility flag---the identifier used to >> +determine whether the breakpoint is visible to the user when set, or >> +when the @samp{info breakpoints} command is run. > > There's no need to go through identifiers. How about this rewording? > > This attribute tells whether the breakpoint is visible to the user > when set, or when the @samp{info breakpoints} command is run. > Works for me. Cheers, Phil