From: Tom Tromey <tromey@redhat.com>
To: "Scott J. Goldman" <scottjg@vmware.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add support for `user-defined` python commands
Date: Thu, 19 May 2011 16:44:00 -0000 [thread overview]
Message-ID: <m3wrhmbpxz.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1305761175-10188-1-git-send-email-scottjg@vmware.com> (Scott J. Goldman's message of "Wed, 18 May 2011 16:26:15 -0700")
>>>>> "Scott" == Scott J Goldman <scottjg@vmware.com> writes:
Scott> For codebases with a large pre-existing set of legacy gdb macros, it's
Scott> nice to be able to use `help user-defined`, to refresh your memory wrt
Scott> to existing macros. Currently, python gdb commands can't put themselves
Scott> under the `user-defined` category. This patch aims to rectify that.
Thanks.
The code bits look ok. I could not tell from the ensuing thread whether
Doug objected to this patch or not. So, my approval is conditional on
him not objecting.
Do you have a copyright assignment in place? This patch probably
requires one. If not, let me know, and I can get you started on that.
This needs a doc review.
Tom
next prev parent reply other threads:[~2011-05-19 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 23:28 Scott J. Goldman
2011-05-19 1:59 ` Doug Evans
2011-05-19 2:54 ` Scott Goldman
2011-05-19 3:08 ` Doug Evans
2011-05-19 16:44 ` Tom Tromey [this message]
2011-05-19 19:27 ` Scott Goldman
2011-05-19 20:23 ` Tom Tromey
2011-05-19 23:16 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wrhmbpxz.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=scottjg@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox