From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 524 invoked by alias); 21 Jun 2011 16:46:38 -0000 Received: (qmail 495 invoked by uid 22791); 21 Jun 2011 16:46:35 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Jun 2011 16:46:17 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5LGjWBJ025709 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 21 Jun 2011 12:46:09 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5LGiCgT031251; Tue, 21 Jun 2011 12:44:13 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p5LGiBJS018173; Tue, 21 Jun 2011 12:44:11 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [4/6] make catchpoints a bit more OO: catch exec References: <201106202123.01154.pedro@codesourcery.com> Date: Tue, 21 Jun 2011 16:46:00 -0000 In-Reply-To: <201106202123.01154.pedro@codesourcery.com> (Pedro Alves's message of "Mon, 20 Jun 2011 21:23:00 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00286.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> +/* Initialize a new breakpoint of the bp_catchpoint kind. If TEMPFLAG Pedro> + is non-zero, then make the breakpoint temporary. If COND_STRING is Pedro> + not NULL, then store it in the breakpoint. OPS, if not NULL, is Pedro> + the breakpoint_ops structure associated to the catchpoint. */ Pedro> + Pedro> +/* An instance of this type is used to represent an exec catchpoint. Pedro> + It includes a "struct breakpoint" as a kind of base class; users Pedro> + downcast to "struct breakpoint *" when needed. A breakpoint is Pedro> + really of this type iff its ops pointer points to Pedro> + CATCH_EXEC_BREAKPOINT_OPS. */ Pedro> + I think that first comment is misplaced. Tom