From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9223 invoked by alias); 15 Jul 2011 20:47:00 -0000 Received: (qmail 9214 invoked by uid 22791); 15 Jul 2011 20:46:59 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Jul 2011 20:46:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6FKkhf0011272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Jul 2011 16:46:43 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6FKkhh8024257; Fri, 15 Jul 2011 16:46:43 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6FKkfr9025633; Fri, 15 Jul 2011 16:46:42 -0400 From: Tom Tromey To: Sterling Augustine Cc: gdb-patches@sourceware.org Subject: Re: [Patch] More responsive QUITs References: Date: Fri, 15 Jul 2011 20:49:00 -0000 In-Reply-To: (Sterling Augustine's message of "Tue, 12 Jul 2011 15:51:29 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00404.txt.bz2 >>>>> "Sterling" == Sterling Augustine writes: Sterling> Enclosed is a patch that adds calls to QUIT in various places which Sterling> makes GDB more responsive to CTRL-C. In particular, reading a symbol Sterling> file at start up can now be interrupted (although perhaps still not as Sterling> responsive as one might like), as well as various other long running Sterling> operations. I know at least two GDB developers have one or another of Sterling> these on their TODO lists. Yeah, I'm one of those. Sterling> All three of these calls to QUIT have relatively close cleanup Sterling> handlers: [...] I agree these are safe as to their immediate surrounds; but the problem is what happens later on. That is, I think a quit when building psymtabs will just leave the remaining psymtabs unread. This will greatly interfere with debugging. We have lazy psymtab reading now. So, it is tempting to try to record where the processing was stopped and then restart it there. However, this may be difficult to do without leaking memory, due to the use of obstacks. Perhaps some leakage would be ok, though; or maybe by making the granularity a single psymtab it would be possible not to leak at all (not sure). Tom