From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82539-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4721 invoked by alias); 22 Jul 2011 17:33:28 -0000
Received: (qmail 4713 invoked by uid 22791); 22 Jul 2011 17:33:27 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jul 2011 17:33:07 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6MHX0m6019855	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 22 Jul 2011 13:33:00 -0400
Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6MHWxpg006136;	Fri, 22 Jul 2011 13:32:59 -0400
From: Phil Muldoon <pmuldoon@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [0/6] breakpoints_ops for all kinds of breakpoints
References: <201107221640.25105.pedro@codesourcery.com>
Reply-to: pmuldoon@redhat.com
X-URL: http://www.redhat.com
Date: Fri, 22 Jul 2011 17:38:00 -0000
In-Reply-To: <201107221640.25105.pedro@codesourcery.com> (Pedro Alves's	message of "Fri, 22 Jul 2011 16:40:25 +0100")
Message-ID: <m3wrfajk50.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00634.txt.bz2

Pedro Alves <pedro@codesourcery.com> writes:

> I did yet a bit more work on:
>
>  <http://sourceware.org/ml/gdb-patches/2011-06/msg00374.html>
>
> This converts all breakpoint kinds to the breakpoint_ops
> mechanism.
>
> IMO, this is committable as is.  WDYT?

I think it is great.  It clears up several (dozen) ambiguities with
breakpoint operations.  I don't think this will affect the Python
breakpoint_ops work (other than some refactoring, but we'll come to that
bridge when your work is checked in).  

Thanks for this patch.

Cheers,

Phil