From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9994 invoked by alias); 4 Oct 2011 20:19:19 -0000 Received: (qmail 9983 invoked by uid 22791); 4 Oct 2011 20:19:18 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SARE_SUB_IMPROVE,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Oct 2011 20:19:00 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p94KJ0uv020268 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Oct 2011 16:19:00 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p94KIxXQ008522; Tue, 4 Oct 2011 16:19:00 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p94KIwHl027140; Tue, 4 Oct 2011 16:18:59 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: PING: [RFA] Improve performance with lots of shared libraries References: <20110922171206.GB5874@redhat.com> <20111004102517.GA2679@redhat.com> Date: Tue, 04 Oct 2011 20:19:00 -0000 In-Reply-To: <20111004102517.GA2679@redhat.com> (Gary Benson's message of "Tue, 4 Oct 2011 11:25:18 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00116.txt.bz2 >>>>> "Gary" == Gary Benson writes: Gary> How is this patch do you think? Is it ok to commit? Gary> 2011-09-22 Gary Benson Gary> * infrun.c (stopped_at_solib_event_breakpoint): New function. Gary> (stopped_at_solib_event_breakpoint_helper): Likewise. Gary> (handle_inferior_event): Avoid calling skip_inline_frames Gary> when at the solib event breakpoint. It looks reasonable to me, but I would much prefer a review from Pedro. Tom