From: Jim Blandy <jimb@codesourcery.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, drow@false.org
Subject: Re: [RFC][1/2] Rework value_from_register
Date: Thu, 04 Jan 2007 20:48:00 -0000 [thread overview]
Message-ID: <m3vejmtt53.fsf@codesourcery.com> (raw)
In-Reply-To: <200612081550.kB8FoueU011723@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Fri, 8 Dec 2006 16:50:56 +0100 (CET)")
"Ulrich Weigand" <uweigand@de.ibm.com> writes:
> ChangeLog:
>
> * frame.c (get_frame_register_bytes): New function.
> (put_frame_register_bytes): Likewise.
> * frame.h (get_frame_register_bytes): Declare.
> (put_frame_register_bytes): Likewise.
> * findvar.c (value_from_register): Always construct lval_register
> values. Use get_frame_register_bytes.
> * valops.c (value_assign): Use get_frame_register_bytes and
> put_frame_register_bytes.
This looks great. Tested without regressions on IA-32 Fedora Core 6.
One suggestion: common practice seems to put detailed explanations of
functions' interfaces in frame.h, and place no comment above the
definition in frame.c. I think it's better to have one full
explanation, instead of two that can get out of sync.
next prev parent reply other threads:[~2007-01-04 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 15:51 Ulrich Weigand
2007-01-04 20:48 ` Jim Blandy [this message]
2007-01-08 17:37 ` Ulrich Weigand
2007-01-08 18:12 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vejmtt53.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox