Re: [patch] stack.c, check return value of lookup_symbol

Jim Blandy
2007-07-06T15:21:24Z

msnyder@sonic.net writes:
> Since it's known that lookup_symbol can return NULL, my first impulse
> was to call gdb_assert. That still might be the right thing to do,
> since it indicates some sort of internal fault -- but it seems to
> me that it isn't necessarily fatal, and simply doing nothing is an
> option...

gdb_assert calls internal_error, so it's not going to sweep GDB out
from under the user. And the situation we're talking about here would
be one where we found a symbol in a block, and then looked up that
name in that block and didn't find the symbol. I definitely want to
see an internal error if that happens.