From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59070-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5586 invoked by alias); 6 Oct 2008 22:42:02 -0000
Received: (qmail 5576 invoked by uid 22791); 6 Oct 2008 22:42:01 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Oct 2008 22:41:26 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m96MbI0s026863; 	Mon, 6 Oct 2008 18:37:19 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m96MbHIU016709; 	Mon, 6 Oct 2008 18:37:17 -0400
Received: from opsy.redhat.com (vpn-10-52.bos.redhat.com [10.16.10.52]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m96MbGjU026572; 	Mon, 6 Oct 2008 18:37:16 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 45917378660; Mon,  6 Oct 2008 16:35:27 -0600 (MDT)
To: Joel Brobecker <brobecker@adacore.com>
Cc: Michael Snyder <msnyder@vmware.com>,         "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,         Daniel Jacobowitz <drow@false.org>,         Pedro Alves <pedro@codesourcery.com>, teawater <teawater@gmail.com>
Subject: Re: [RFA] Reverse Debugging, 4/5
References: <48E3CD40.3070206@vmware.com> <20081006215637.GE21853@adacore.com>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
X-Attribution:  Tom
Date: Mon, 06 Oct 2008 22:42:00 -0000
In-Reply-To: <20081006215637.GE21853@adacore.com> (Joel Brobecker's message of "Mon\, 6 Oct 2008 17\:56\:37 -0400")
Message-ID: <m3vdw58i8g.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-10/txt/msg00186.txt.bz2

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Michael> +void
Michael> +breakpoint_silence (struct breakpoint *b)
Michael> +{
Michael> +  /* Silence the breakpoint.  */
Michael> +  b->silent = 1;

Joel> Minor nit: This name brings little meaning when I see it being called.
Joel> Can we change it to "make_breakpoint_silent"?  That way, the comment
Joel> in the body becomes useless and can be removed.

The Python breakpoint wrapper directly sets or clears b->silent.
Perhaps we could make this a generic setter in anticipation of that
patch?

Tom