From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6727 invoked by alias); 25 Oct 2008 16:05:48 -0000 Received: (qmail 6713 invoked by uid 22791); 25 Oct 2008 16:05:46 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 25 Oct 2008 16:05:11 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m9PG3oKc013088; Sat, 25 Oct 2008 12:03:50 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m9PG3mSO005683; Sat, 25 Oct 2008 12:03:49 -0400 Received: from opsy.redhat.com (vpn-12-162.rdu.redhat.com [10.11.12.162]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m9PG3lJS004754; Sat, 25 Oct 2008 12:03:47 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C910F88810F; Sat, 25 Oct 2008 10:03:46 -0600 (MDT) To: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org Subject: Re: [RFC/RFA] add struct parse_context to all command functions References: <200810241300.m9OD0X69010748@d12av02.megacenter.de.ibm.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Sat, 25 Oct 2008 16:05:00 -0000 In-Reply-To: <200810241300.m9OD0X69010748@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Fri\, 24 Oct 2008 15\:00\:33 +0200 \(CEST\)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00641.txt.bz2 Ulrich> Thanks! The patch looks good to me now, so if testing goes well, Ulrich> this is OK. Just FYI -- it will be a while longer. I realized today that the treatment of output_format is different with the patch. In particular, the old code distinguishes between the format that is passed in and the global output_format in some places, but the new code does not. One way to see this is by setting output-radix. Before the patch: (gdb) set output-radix 8 (gdb) print enum_constant $1 = enum_constant But after: (gdb) set output-radix 8 (gdb) print enum_constant $1 = 01 I'll go back and introduce a second 'format' field in value_print_options, unless someone has a better idea. This behavior is not tested for. So, I'll also add some test cases. I can send the current patch if you want it for something more immediate. Relative to the previous one it has some bug fixes plus a ChangeLog entry. Tom