From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 482 invoked by alias); 20 Jun 2009 07:17:19 -0000 Received: (qmail 457 invoked by uid 22791); 20 Jun 2009 07:17:17 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Jun 2009 07:17:12 +0000 Received: from zps18.corp.google.com (zps18.corp.google.com [172.25.146.18]) by smtp-out.google.com with ESMTP id n5K7H9fg000520; Sat, 20 Jun 2009 00:17:10 -0700 Received: from wf-out-1314.google.com (wfc25.prod.google.com [10.142.3.25]) by zps18.corp.google.com with ESMTP id n5K7H7sk001182; Sat, 20 Jun 2009 00:17:07 -0700 Received: by wf-out-1314.google.com with SMTP id 25so727262wfc.25 for ; Sat, 20 Jun 2009 00:17:07 -0700 (PDT) Received: by 10.142.133.19 with SMTP id g19mr1697699wfd.126.1245482227278; Sat, 20 Jun 2009 00:17:07 -0700 (PDT) Received: from localhost.localdomain.google.com (adsl-71-133-8-30.dsl.pltn13.pacbell.net [71.133.8.30]) by mx.google.com with ESMTPS id 29sm60512wfg.8.2009.06.20.00.17.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 20 Jun 2009 00:17:06 -0700 (PDT) To: Tom Tromey Cc: gcc-patches@gcc.gnu.org, Binutils Development , gdb-patches@sourceware.org Subject: Re: Patch: merge src and gcc copies of dwarf2.h References: From: Ian Lance Taylor Date: Sat, 20 Jun 2009 07:17:00 -0000 In-Reply-To: (Tom Tromey's message of "Fri\, 19 Jun 2009 15\:11\:16 -0600") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00527.txt.bz2 Tom Tromey writes: > * Files in include/ are still GPLv2. > I made the new dwarf2.h GPLv3, but GCC's copy has the exception text > as well. I believe the file in include/ should also have the exception text. The question to ask is: might a plugin want to include this file? If yes, it should have the exception text. > * gcc's dwarf2.h defines INTERNAL_DW_OP_tls_addr. > I left this in there, but IMO it is somewhat of a hack. > Perhaps it should be local to gcc, like: > > #define INTERNAL_DW_OP_tls_addr (enum dwarf_location_atom) 0x103 That would not work reliably in C++ since it would be out of range of the other enum values. > Or maybe be made an explicit flag somewhere instead of abusing an > enum. That would be fine. > Bootstrapped and regtested on x86-64 (compile farm). > Ok? And for src, assuming that there are no regressions? This is OK for gcc if you use the exception text in the license. Thanks. Ian