From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29221 invoked by alias); 26 Jan 2010 21:54:31 -0000 Received: (qmail 29212 invoked by uid 22791); 26 Jan 2010 21:54:31 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Jan 2010 21:54:26 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0QLsOTU010010 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Jan 2010 16:54:24 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0QLsOCn030280; Tue, 26 Jan 2010 16:54:24 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o0QLsNBx017483; Tue, 26 Jan 2010 16:54:23 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id A676237819A; Tue, 26 Jan 2010 14:54:22 -0700 (MST) From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: [1/4] RFC: refactor partial symbol tables References: <20100126214550.GD17877@caradoc.them.org> Reply-To: Tom Tromey Date: Tue, 26 Jan 2010 21:54:00 -0000 In-Reply-To: <20100126214550.GD17877@caradoc.them.org> (Daniel Jacobowitz's message of "Tue, 26 Jan 2010 16:45:50 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00583.txt.bz2 >>>>> "Daniel" == Daniel Jacobowitz writes: Daniel> Overall, I very much like this series and think it should go in. Thanks. Daniel> Have you considered the case of objfiles with multiple formats of Daniel> debug info? This used to be a very common case, where the system Daniel> libraries had some stabs data and the user code had dwarf-2. It's Daniel> probably still happening on various platforms. So it seems like Daniel> we need to be able to query multiple symbol readers' qf functions, Daniel> potentially. I did consider this, and I (safely) punted. On my branch, the only non-psymtab implementation of the quick API is in dwarf2read.c, and that code bails out and reverts to using psymtabs if it find that any other reader has created psymtabs for the objfile. I'm not sure how hard it would be to do something nicer. I didn't look closely but I think that not all of the APIs compose nicely. Tom