From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14352 invoked by alias); 5 Mar 2010 16:02:01 -0000 Received: (qmail 14300 invoked by uid 22791); 5 Mar 2010 16:02:00 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Mar 2010 16:01:56 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o25G1YnE019526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 5 Mar 2010 11:01:34 -0500 Received: from ns3.rdu.redhat.com ([10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o25G1X6k032758; Fri, 5 Mar 2010 11:01:33 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o25G1Wqo014902; Fri, 5 Mar 2010 11:01:32 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 2B15B379315; Fri, 5 Mar 2010 09:01:32 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: FYI: DW_FORM_ref_addr -vs- DWARF 3 References: <20100305045834.GL2832@adacore.com> Reply-To: Tom Tromey Date: Fri, 05 Mar 2010 16:02:00 -0000 In-Reply-To: <20100305045834.GL2832@adacore.com> (Joel Brobecker's message of "Fri, 5 Mar 2010 08:58:34 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00233.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> Hi Tom, >> 2010-03-04 Tom Tromey >> >> * dwarf2read.c (skip_one_die) : Use offset size >> in DWARF 3 and later. >> (read_attribute_value) : Likewise. Joel> This patch looks fine to me for head and branch. I don't know which Joel> version I prefer, between Jim's and yours, but yours is smaller :). :) Thanks, I checked this in to the 7.1 branch as well. Tom