From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31882 invoked by alias); 24 Aug 2010 21:14:25 -0000 Received: (qmail 31874 invoked by uid 22791); 24 Aug 2010 21:14:24 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Aug 2010 21:14:18 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7OLEEcO011897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 24 Aug 2010 17:14:14 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7OLED0t011567; Tue, 24 Aug 2010 17:14:13 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7OLECoc026075; Tue, 24 Aug 2010 17:14:13 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id A66293780C2; Tue, 24 Aug 2010 15:14:12 -0600 (MDT) From: Tom Tromey To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFA] symtab/11942: rewrite dwarf2read.c type_hash usage References: <20100824000327.7787684B8E@ruffy.mtv.corp.google.com> Date: Tue, 24 Aug 2010 21:14:00 -0000 In-Reply-To: (Doug Evans's message of "Tue, 24 Aug 2010 01:29:54 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00424.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> Apologies for the follow-up. Doug> Further testing revealed I messed up signatured type lookups in Doug> lookup_die_type (old code that didn't get revisited in my final review Doug> before submission). Doug> Here's a new patch. I read through this and it seems reasonable to me. Tom