Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Patch: fix #line directives in bison output
Date: Mon, 22 Nov 2010 20:26:00 -0000	[thread overview]
Message-ID: <m3vd3p6r77.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20101120050752.GO2634@adacore.com> (Joel Brobecker's message of	"Fri, 19 Nov 2010 21:07:52 -0800")

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I'll admit being lazy this evening and not having the energy trying to
Joel> understand the incantations being used in the makefile, and why we have
Joel> to make the following targets non-.PRECIOUS.

If they are .PRECIOUS, then an interrupt means that the file will not be
removed.  However, the patched rule creates the target file as the
output of $(YLWRAP).  If an interrupt came just after ylwrap finished,
then an incorrect .c file would be left, breaking future builds.

Joel> Something did catch my eye, though:

>> -.PRECIOUS: ada-exp.c ada-lex.c
>> -.PRECIOUS: c-exp.c
>> -.PRECIOUS: f-exp.c
>> -.PRECIOUS: jv-exp.c
>> -.PRECIOUS: m2-exp.c
>> -.PRECIOUS: objc-exp.c
>> -.PRECIOUS: p-exp.c
>> +.PRECIOUS: ada-exp.c

Joel> Did you mean the last line to be "ada-lex.c"?

Yeah, oops.
I will fix it shortly.

Tom


  reply	other threads:[~2010-11-22 20:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19 18:10 Tom Tromey
2010-11-20  5:08 ` Joel Brobecker
2010-11-22 20:26   ` Tom Tromey [this message]
2010-11-22 20:31     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vd3p6r77.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox