From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3402 invoked by alias); 14 Dec 2010 17:02:56 -0000 Received: (qmail 3335 invoked by uid 22791); 14 Dec 2010 17:02:53 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 17:02:47 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBEH2kLL008142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Dec 2010 12:02:46 -0500 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oBEH2ira012769; Tue, 14 Dec 2010 12:02:45 -0500 From: Phil Muldoon To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch] Add an evaluation function hook to Python breakpoints. References: Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Tue, 14 Dec 2010 17:02:00 -0000 In-Reply-To: (Tom Tromey's message of "Tue, 14 Dec 2010 09:35:48 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00242.txt.bz2 Tom Tromey writes: >>>>>> "Phil" == Phil Muldoon writes: > > Phil> + PyObject *gdbpy_bp_eval = PyString_FromString ("evaluate"); > > This is leaked. However... > > Phil> + if (PyObject_HasAttr (py_bp, gdbpy_bp_eval)) > Phil> + { > Phil> + PyObject *result = PyObject_CallMethodObjArgs (py_bp, > Phil> + gdbpy_bp_eval, > Phil> + NULL); > > You can just use PyObject_HasAttrString and PyObject_CallMethod instead. Ok, thanks. > Phil> +gdb_py_test_silent_cmd "python eval_bp1 = bp_eval(\"$bp_location2\")" "Set breakpoint" 0 > Phil> +gdb_py_test_silent_cmd "python also_eval_bp1 = bp_also_eval(\"$bp_location2\")" "Set breakpoint" 0 > > I think there should also be a test for the case where there is an > ordinary user breakpoint at the same location as the Python breakpoints. > In this case, the user breakpoint should stop, but all the Python > methods should be invoked first. All the breakpoints at a location will be evaluated, but does the order matter? I can add the test to prove the point, but the Python breakpoints will have the evaluation function called regardless if the user breakpoint was first. FWIW in bpstop_stop_status a bpstat chain is built from the location where the inferior stopped. Then later, we iterate through that chain and eventually call bpstat_check_breakpoint_conditions. Then finally in that condition call we evaluate the Python function. This loop does not exit until the all the bpstats in the chain have been iterated. Cheers Phil